Vergara_Tech/zenith
Vergara_Tech/zenith
2
0
Fork 0
Code Issues 24 Pull requests Projects Releases 6 Packages Wiki Activity

rvv041 #82

Merged
pitmutt merged 30 commits from rvv041 into milestone2 2024-06-07 20:03:06 +00:00
Conversation 0 Commits 30 Files changed 9 +406 -49
reneve commented 2024-05-13 00:52:03 +00:00
Owner
Copy link

Address book table added to DB.hs
getAdrBook function to retrieve a list of addresses created.

Address book table added to DB.hs getAdrBook function to retrieve a list of addresses created.
reneve added 6 commits 2024-05-13 00:52:04 +00:00 
Co-authored-by: Rene V. Vergara <rvergara59@protonmail.com>
Reviewed-on: #80
Co-authored-by: pitmutt <rene@vergara.network>
Co-committed-by: pitmutt <rene@vergara.network>
getAdrBook function to get a list of all addresses
         recorded in AddressBook table
pitmutt added the
enhancement
 label 2024-05-13 19:31:55 +00:00
pitmutt added this to the MVP 2 milestone 2024-05-13 19:31:58 +00:00
pitmutt added this to the Zenith Full Node Wallet project 2024-05-13 19:32:00 +00:00
pitmutt changed target branch from dev041 to milestone2 2024-05-13 19:32:29 +00:00
reneve added 1 commit 2024-05-13 20:28:52 +00:00 
address field in address book changed to T.Text
reneve added 1 commit 2024-05-14 22:20:27 +00:00 
delete record using AddressBookId
reneve added 1 commit 2024-05-23 12:45:39 +00:00
reneve added 1 commit 2024-05-24 13:53:46 +00:00
reneve added 1 commit 2024-05-24 14:36:50 +00:00 
Options for Address Book and Help windows added
reneve added 2 commits 2024-05-25 01:28:08 +00:00 
new attributes created for the box
	 At this stage, the Evenhandler is processing the exit command only
         to close the window and return to the main window.
- Functionality to copy receiver address to Clipboard  added
	- Functionality to Send Zcash to selected AddresBook entry added
reneve added 1 commit 2024-05-25 01:58:16 +00:00 
- Check added ::   value to send has to be > 0 and <= balance
reneve added 1 commit 2024-05-30 21:32:31 +00:00 
Form to create a new Address Book entry
	Error control added to the form.
reneve added 1 commit 2024-05-31 22:41:15 +00:00 
DB.hs updated -
	   updateAdrsInAdrBook :: ConnectionPool -> T.Text -> T.Text -> T.Text -> IO ()
	 CLI.hs updated
reneve added 1 commit 2024-06-01 02:21:19 +00:00 
Delete addressbook entry in progress
reneve added 1 commit 2024-06-01 22:08:24 +00:00 
Added a  window to show a address book entry
	 It is activated pressing Enter inside Address Book window
reneve added 1 commit 2024-06-02 00:07:27 +00:00
reneve added 1 commit 2024-06-02 00:21:56 +00:00
reneve added 1 commit 2024-06-02 13:11:06 +00:00
pitmutt approved these changes 2024-06-03 14:15:03 +00:00
pitmutt reviewed 2024-06-03 14:55:14 +00:00
CHANGELOG.md Outdated
@ -7,6 +7,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [0.5.2.0-beta]
### Added
pitmutt commented 2024-06-03 14:51:14 +00:00
Owner
Copy link

These changes should be added as a new version [0.5.3.0-beta]

These changes should be added as a new version `[0.5.3.0-beta]`
pitmutt marked this conversation as resolved
src/Zenith/CLI.hs Outdated
@ -2,6 +2,7 @@
{-# LANGUAGE TypeApplications #-}
{-# LANGUAGE OverloadedStrings #-}
{-# LANGUAGE ScopedTypeVariables #-}
{-# LANGUAGE BlockArguments #-}
pitmutt commented 2024-06-03 14:30:17 +00:00
Owner
Copy link

This option is not required.

This option is not required.
pitmutt marked this conversation as resolved
src/Zenith/CLI.hs
@ -125,2 +136,4 @@
makeLenses ''SendInput
data AdrBookEntry = AdrBookEntry
{ _descrip :: !T.Text
pitmutt commented 2024-06-03 14:31:55 +00:00
Owner
Copy link

The name of the field should be _abDescrip so the there are no conflict with the lens.

The name of the field should be `_abDescrip` so the there are no conflict with the lens.
pitmutt commented 2024-06-03 19:11:35 +00:00
Owner
Copy link

@reneve It's better to use more specific name fields to avoid conflicts.

@reneve It's better to use more specific name fields to avoid conflicts.
pitmutt marked this conversation as resolved
src/Zenith/CLI.hs
@ -126,1 +137,4 @@
data AdrBookEntry = AdrBookEntry
{ _descrip :: !T.Text
, _address :: !T.Text
pitmutt commented 2024-06-03 14:32:43 +00:00
Owner
Copy link

The name of the field should be _abAddress so no conflicts with existing fields are found.

The name of the field should be `_abAddress` so no conflicts with existing fields are found.
pitmutt marked this conversation as resolved
src/Zenith/CLI.hs Outdated
@ -169,6 +192,10 @@ data State = State
, _eventDispatch :: !(BC.BChan Tick)
, _timer :: !Int
, _txForm :: !(Form SendInput () Name)
, _abaddresses :: !(L.List Name (Entity AddressBook))
pitmutt commented 2024-06-03 14:42:58 +00:00
Owner
Copy link

The field should be named _abAddresses

The field should be named `_abAddresses`
pitmutt marked this conversation as resolved
src/Zenith/CLI.hs Outdated
@ -171,1 +194,4 @@
, _txForm :: !(Form SendInput () Name)
, _abaddresses :: !(L.List Name (Entity AddressBook))
, _abForm :: !(Form AdrBookEntry () Name)
, _abCurAdrs :: !T.Text
pitmutt commented 2024-06-03 14:46:40 +00:00
Owner
Copy link

What is this field for?

What is this field for?
pitmutt marked this conversation as resolved
src/Zenith/CLI.hs Outdated
@ -172,0 +195,4 @@
, _abaddresses :: !(L.List Name (Entity AddressBook))
, _abForm :: !(Form AdrBookEntry () Name)
, _abCurAdrs :: !T.Text
, _abTxt :: !T.Text
pitmutt commented 2024-06-03 14:46:50 +00:00
Owner
Copy link

What is this field for?

What is this field for?
pitmutt marked this conversation as resolved
src/Zenith/CLI.hs Outdated
@ -1047,3 +1323,3 @@
True
(mkInputForm $ DialogInput "Main")
(F.focusRing [AList, TList])
(F.focusRing [AList, TList,ABList])
pitmutt commented 2024-06-03 14:37:58 +00:00
Owner
Copy link

The ABList needs to be removed from the focus ring, it is not visible on the main screen.

The `ABList` needs to be removed from the focus ring, it is not visible on the main screen.
pitmutt marked this conversation as resolved
src/Zenith/DB.hs Outdated
@ -15,6 +15,7 @@
{-# LANGUAGE FlexibleInstances #-}
{-# LANGUAGE TypeOperators #-}
{-# LANGUAGE TypeApplications #-}
{-# LANGUAGE BlockArguments #-}
pitmutt commented 2024-06-03 14:30:44 +00:00
Owner
Copy link

This option is not required

This option is not required
pitmutt marked this conversation as resolved
src/Zenith/DB.hs Outdated
@ -1470,0 +1505,4 @@
where_ $ ab ^. AddressBookAddress ==. val ia
-- | Get one AddrssBook record using the Address as a key
getABookRec :: ConnectionPool -> T.Text -> IO [Entity AddressBook]
pitmutt commented 2024-06-03 14:28:06 +00:00
Owner
Copy link

If this function is intended to provide only one record, it should return a IO (Maybe (Entity AddressBook))

If this function is intended to provide only one record, it should return a `IO (Maybe (Entity AddressBook))`
pitmutt marked this conversation as resolved
reneve added 4 commits 2024-06-03 18:54:38 +00:00 
ABList removed from focusRing
	 address_book's column address renamed to abaddress
addressbook's column descrip renamed to abdescrip
	 _abText - variable used to hold AddressBook entry data for display
	 _abCurAdrs - variable used to hold unique key in CRUD operations
getABookRec function commented out from DB.hs
	 abaddresses state renamed to abAddresses
reneve added 1 commit 2024-06-03 19:03:23 +00:00 
addressBookDescrip changed to addressBookAbdescrip
	 DB.hs and CLI.hs source files affected
reneve added 1 commit 2024-06-03 22:22:58 +00:00 
list  is empty
	       Fixed  -> RefreshAddressBook function reviwed and corrected
reneve added 1 commit 2024-06-04 01:48:27 +00:00 
- abText state variable removed
	 - AdrBookEntryDisplay refactored to use abAddresses state variable
reneve added 1 commit 2024-06-04 02:15:26 +00:00 
- Some comments removed
pitmutt requested review from pitmutt 2024-06-04 12:18:38 +00:00
pitmutt requested changes 2024-06-04 12:24:47 +00:00
pitmutt left a comment
Owner
Copy link

Please review the comments on the copy address message.

Please review the comments on the copy address message.
src/Zenith/CLI.hs Outdated
@ -923,0 +1061,4 @@
set msg $
"Address copied to Clipboard from >>\n" ++
T.unpack (addressBookAbdescrip (entityVal a)) ++ "->\n" ++
T.unpack (addressBookAbaddress (entityVal a)) ++ "!"
pitmutt commented 2024-06-04 12:21:53 +00:00
Owner
Copy link

It is not necessary to show the address, it is too long for the message window. We should only use the name in the message.

It is not necessary to show the address, it is too long for the message window. We should only use the name in the message.
pitmutt marked this conversation as resolved
reneve was assigned by pitmutt 2024-06-04 12:25:21 +00:00
reneve added 1 commit 2024-06-05 00:17:08 +00:00 
Address removed from Message windown in Copy Address Action result
reneve added 1 commit 2024-06-06 00:47:43 +00:00 
Some UI changes
pitmutt added 1 commit 2024-06-06 11:01:56 +00:00
pitmutt merged commit 122d24a929 into milestone2 2024-06-07 20:03:06 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
pitmutt
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
MVP 2
Projects
Clear projects
No items
No project
Zenith Full Node Wallet
Assignees
Clear assignees
No assignees
reneve
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Vergara_Tech/zenith#82
No description provided.
Delete branch "rvv041"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?