rvv041 #82
No reviewers
Labels
No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: Vergara_Tech/zenith#82
Loading…
Reference in a new issue
No description provided.
Delete branch "rvv041"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Address book table added to DB.hs
getAdrBook function to retrieve a list of addresses created.
@ -7,6 +7,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [0.5.2.0-beta]
### Added
These changes should be added as a new version
[0.5.3.0-beta]
@ -2,6 +2,7 @@
{-# LANGUAGE TypeApplications #-}
{-# LANGUAGE OverloadedStrings #-}
{-# LANGUAGE ScopedTypeVariables #-}
{-# LANGUAGE BlockArguments #-}
This option is not required.
@ -125,2 +136,4 @@
makeLenses ''SendInput
data AdrBookEntry = AdrBookEntry
{ _descrip :: !T.Text
The name of the field should be
_abDescrip
so the there are no conflict with the lens.@reneve It's better to use more specific name fields to avoid conflicts.
@ -126,1 +137,4 @@
data AdrBookEntry = AdrBookEntry
{ _descrip :: !T.Text
, _address :: !T.Text
The name of the field should be
_abAddress
so no conflicts with existing fields are found.@ -169,6 +192,10 @@ data State = State
, _eventDispatch :: !(BC.BChan Tick)
, _timer :: !Int
, _txForm :: !(Form SendInput () Name)
, _abaddresses :: !(L.List Name (Entity AddressBook))
The field should be named
_abAddresses
@ -171,1 +194,4 @@
, _txForm :: !(Form SendInput () Name)
, _abaddresses :: !(L.List Name (Entity AddressBook))
, _abForm :: !(Form AdrBookEntry () Name)
, _abCurAdrs :: !T.Text
What is this field for?
@ -172,0 +195,4 @@
, _abaddresses :: !(L.List Name (Entity AddressBook))
, _abForm :: !(Form AdrBookEntry () Name)
, _abCurAdrs :: !T.Text
, _abTxt :: !T.Text
What is this field for?
@ -1047,3 +1323,3 @@
True
(mkInputForm $ DialogInput "Main")
(F.focusRing [AList, TList])
(F.focusRing [AList, TList,ABList])
The
ABList
needs to be removed from the focus ring, it is not visible on the main screen.@ -15,6 +15,7 @@
{-# LANGUAGE FlexibleInstances #-}
{-# LANGUAGE TypeOperators #-}
{-# LANGUAGE TypeApplications #-}
{-# LANGUAGE BlockArguments #-}
This option is not required
@ -1470,0 +1505,4 @@
where_ $ ab ^. AddressBookAddress ==. val ia
-- | Get one AddrssBook record using the Address as a key
getABookRec :: ConnectionPool -> T.Text -> IO [Entity AddressBook]
If this function is intended to provide only one record, it should return a
IO (Maybe (Entity AddressBook))
Please review the comments on the copy address message.
@ -923,0 +1061,4 @@
set msg $
"Address copied to Clipboard from >>\n" ++
T.unpack (addressBookAbdescrip (entityVal a)) ++ "->\n" ++
T.unpack (addressBookAbaddress (entityVal a)) ++ "!"
It is not necessary to show the address, it is too long for the message window. We should only use the name in the message.
prepareTx
f89e9b72ca