Vergara_Tech/zenith
Vergara_Tech/zenith
2
0
Fork 0
Code Issues 32 Pull requests Projects Releases 6 Packages Wiki Activity

Add base addressbook to GUI #102

Merged
pitmutt merged 21 commits from rvv041 into milestone3 2024-09-13 11:39:59 +00:00
Conversation 0 Commits 21 Files changed 6 +379 -12
pitmutt commented 2024-08-03 12:20:10 +00:00
Owner
Copy link
No description provided.
pitmutt added this to the MVP 3 milestone 2024-08-03 12:20:10 +00:00
pitmutt added the
enhancement
 label 2024-08-03 12:20:10 +00:00
reneve was assigned by pitmutt 2024-08-03 12:20:10 +00:00
pitmutt added 5 commits 2024-08-03 12:20:12 +00:00
pitmutt added this to the Zenith Full Node Wallet project 2024-08-03 12:20:14 +00:00
pitmutt reviewed 2024-08-03 12:38:33 +00:00
pitmutt left a comment
Author
Owner
Copy link

The docker image needs to be removed from this branch before merging.

The docker image needs to be removed from this branch before merging.
src/Zenith/GUI.hs Outdated
@ -185,6 +190,8 @@ buildUI wenv model = widgetTree
, txIdOverlay `nodeVisible` isJust (model ^. showId)
, msgOverlay `nodeVisible` isJust (model ^. msg)
, modalOverlay `nodeVisible` isJust (model ^. modalMsg)
, adrbookOverlay `nodeVisible` model ^. showAdrBook
pitmutt commented 2024-08-03 12:34:33 +00:00
Author
Owner
Copy link

Any new windows should be lower priority than msgOverlay, so the message window displays above. Also, the wallet sync notification uses modalOverlay and needs to be the top widget to make sure that no activities are performed during sync.

Any new windows should be lower priority than `msgOverlay`, so the message window displays above. Also, the wallet sync notification uses `modalOverlay` and needs to be the top widget to make sure that no activities are performed during sync.
pitmutt marked this conversation as resolved
src/Zenith/GUI.hs Outdated
@ -753,0 +778,4 @@
]
]
notImplemented = NotImplemented
pitmutt commented 2024-08-03 12:26:13 +00:00
Author
Owner
Copy link

This is unnecessary, the event can be used directly

This is unnecessary, the event can be used directly
pitmutt marked this conversation as resolved
src/Zenith/GUI.hs Outdated
@ -1062,1 +1091,4 @@
ShowTxId tx -> [Model $ model & showId ?~ tx & modalMsg .~ Nothing]
ShowAdrBook -> [Model $ model & showAdrBook .~ True & menuPopup .~ False]
CloseAdrBook -> [Model $ model & showAdrBook .~ False]
NotImplemented -> [Model $ model & msg ?~ "Function not implemented..." & menuPopup .~ False & modalMsg .~ Nothing]
pitmutt commented 2024-08-03 12:32:34 +00:00
Author
Owner
Copy link

Using model & msg ?~ ... uses the msgOverlay dialog box that is lower in the widgetTree priority.

Using `model & msg ?~ ...` uses the `msgOverlay` dialog box that is lower in the `widgetTree` priority.
pitmutt marked this conversation as resolved
src/Zenith/GUI.hs Outdated
@ -1329,3 +1360,1 @@
if not (null accList)
then Just (head accList)
else Nothing)
(SaveAddress (if not (null accList)
pitmutt commented 2024-08-03 12:35:56 +00:00
Author
Owner
Copy link

Too many parenthesis, use $ instead.

Too many parenthesis, use `$` instead.
pitmutt marked this conversation as resolved
src/Zenith/GUI.hs Outdated
@ -1359,3 +1392,3 @@
[]
0
(Just $
(Just (
pitmutt commented 2024-08-03 12:36:16 +00:00
Author
Owner
Copy link

Too many parenthesis, use $ instead.

Too many parenthesis, use `$` instead.
pitmutt marked this conversation as resolved
src/Zenith/Utils.hs Outdated
@ -93,0 +95,4 @@
getZenithPath :: IO String
getZenithPath = do
d <- getHomeDirectory
let homeDirectory = d
pitmutt commented 2024-08-03 12:37:44 +00:00
Author
Owner
Copy link

This line is redundant, use homeDirectory <- getHomeDirectory directly.

This line is redundant, use `homeDirectory <- getHomeDirectory` directly.
pitmutt marked this conversation as resolved
reneve added 1 commit 2024-08-19 22:18:50 +00:00
pitmutt added 1 commit 2024-08-20 21:46:44 +00:00
pitmutt reviewed 2024-09-03 18:45:00 +00:00
src/Zenith/GUI.hs Outdated
@ -1343,3 +1436,3 @@
False
Nothing
hD
""
pitmutt commented 2024-09-03 18:45:00 +00:00
Author
Owner
Copy link

@reneve Your new fields in the state should be after the hD variable, not before

@reneve Your new fields in the state should be after the `hD` variable, not before
pitmutt marked this conversation as resolved
reneve added 2 commits 2024-09-05 14:18:29 +00:00
reneve added 1 commit 2024-09-05 15:32:46 +00:00
reneve added 1 commit 2024-09-05 17:51:48 +00:00
reneve added 1 commit 2024-09-06 02:23:49 +00:00 
- Show entry zec address on row click
pitmutt added 1 commit 2024-09-06 13:43:14 +00:00
reneve added 1 commit 2024-09-06 21:20:50 +00:00
reneve added 1 commit 2024-09-06 23:53:38 +00:00 
- Edit Adress Book entry in progress.
reneve added 1 commit 2024-09-07 21:16:25 +00:00 
- "Delete entry" button added (functionality not implemented yet)
reneve added 1 commit 2024-09-08 21:40:11 +00:00 
- Delete Address Book Entry working
reneve added 1 commit 2024-09-12 01:38:56 +00:00
pitmutt added 1 commit 2024-09-13 11:38:16 +00:00
pitmutt merged commit bf4118b09d into milestone3 2024-09-13 11:39:59 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
MVP 3
Projects
Clear projects
No items
No project
Zenith Full Node Wallet
Assignees
Clear assignees
No assignees
reneve
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Vergara_Tech/zenith#102
No description provided.
Delete branch "rvv041"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?