Merge pull request 'fix: decode unified addresses with no transparent receivers' (#89) from rav001 into milestone2

Reviewed-on: https://git.vergara.tech///Vergara_Tech/zcash-haskell/pulls/89

CHANGELOG.md

@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.6.2.3]
+
+### Fixed
+
+- Decoding of unified addresses with no transparent receivers
+
 ## [0.6.2.2]
 
 - Added JSON instances for `ZcashNet`

src/ZcashHaskell/Orchard.hs

@@ -103,9 +103,9 @@ isValidUnifiedAddress str =
         (if BS.length (raw_s x) == 43
            then Just $ SaplingReceiver (raw_s x)
            else Nothing)
-        (if not (BS.null (raw_t x))
+        (if BS.length (raw_t x) > 1
            then Just $ TransparentReceiver P2PKH (fromRawBytes $ raw_t x)
-           else if not (BS.null (raw_to x))
+           else if BS.length (raw_to x) > 1
                   then Just $ TransparentReceiver P2SH (fromRawBytes $ raw_to x)
                   else Nothing)
 

test/Spec.hs

@@ -1143,7 +1143,7 @@ main = do
                   case exch of
                     Nothing -> assertFailure "Failed to encode Exchange address"
                     Just addr -> do
-                      let eadr = decodeExchangeAddress addr
+                      let eadr = decodeExchangeAddress (E.encodeUtf8 addr)
                       eadr `shouldNotBe` Nothing
     describe "Witness updates" $ do
       it "Sapling" $ do

zcash-haskell.cabal

@@ -5,7 +5,7 @@ cabal-version: 3.0
 -- see: https://github.com/sol/hpack
 
 name:           zcash-haskell
-version:        0.6.2.2
+version:        0.6.2.3
 synopsis:       Utilities to interact with the Zcash blockchain
 description:    Please see the README on the repo at <https://git.vergara.tech/Vergara_Tech/zcash-haskell#readme>
 category:       Blockchain