From c91e23ab9c38cb16e5acb4a5ee2e7eb3e70d375c Mon Sep 17 00:00:00 2001 From: Rene Vergara Date: Fri, 9 Feb 2024 13:23:58 -0600 Subject: [PATCH 1/3] Add function documentation --- src/ZcashHaskell/Keys.hs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ZcashHaskell/Keys.hs b/src/ZcashHaskell/Keys.hs index c0b8bdc..a3b20b3 100644 --- a/src/ZcashHaskell/Keys.hs +++ b/src/ZcashHaskell/Keys.hs @@ -27,7 +27,7 @@ import ZcashHaskell.Types (Phrase, Seed) generateWalletSeedPhrase :: IO Phrase generateWalletSeedPhrase = withBorshVarBuffer rustWrapperGenSeedPhrase --- | Get +-- | Derive a cryptographic seed from the given seed phrase. getWalletSeed :: Phrase -> Maybe Seed getWalletSeed p = if BS.length result > 0 From 88a5189ebafb17988d0b4d5d90caa4a1a33ee983 Mon Sep 17 00:00:00 2001 From: Rene Vergara Date: Fri, 9 Feb 2024 13:24:34 -0600 Subject: [PATCH 2/3] Add `Read` implementations --- src/ZcashHaskell/Types.hs | 10 +++++----- stack.yaml | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/ZcashHaskell/Types.hs b/src/ZcashHaskell/Types.hs index 2354ca7..c126984 100644 --- a/src/ZcashHaskell/Types.hs +++ b/src/ZcashHaskell/Types.hs @@ -123,27 +123,27 @@ data RawTxResponse = RawTxResponse , rt_blockheight :: Integer , rt_confirmations :: Integer , rt_blocktime :: Integer - } deriving (Prelude.Show, Eq) + } deriving (Prelude.Show, Eq, Read) data ZcashNet = MainNet | TestNet | RegTestNet - deriving (Eq, Prelude.Show) + deriving (Eq, Prelude.Show, Read) -- * Transparent -- | Type to represent the two kinds of transparent addresses data TransparentType = P2SH | P2PKH - deriving (Eq, Prelude.Show) + deriving (Eq, Prelude.Show, Read) -- | Type to represent a transparent Zcash addresses data TransparentAddress = TransparentAddress { ta_type :: !TransparentType , ta_net :: !ZcashNet , ta_bytes :: !BS.ByteString - } deriving (Eq, Prelude.Show) + } deriving (Eq, Prelude.Show, Read) -- * Sapling -- | Type to represent a Sapling Shielded Output as provided by the @getrawtransaction@ RPC method of @zcashd@. @@ -212,7 +212,7 @@ data OrchardAction = OrchardAction , out_ciphertext :: HexString -- ^ A ciphertext enabling the sender to recover the output note , cv :: HexString -- ^ A value commitment to the net value of the input note minus the output note , auth :: HexString -- ^ A signature authorizing the spend in this Action - } deriving stock (Eq, Prelude.Show, GHC.Generic) + } deriving stock (Eq, Prelude.Show, GHC.Generic, Read) deriving anyclass (SOP.Generic, SOP.HasDatatypeInfo) deriving anyclass (Data.Structured.Show) deriving (BorshSize, ToBorsh, FromBorsh) via AsStruct OrchardAction diff --git a/stack.yaml b/stack.yaml index ab6c7c0..b5b06a5 100644 --- a/stack.yaml +++ b/stack.yaml @@ -41,7 +41,7 @@ extra-deps: - git: https://github.com/well-typed/borsh.git commit: d2fcfa159e0a844b1ec5e8ed3e232d4b380fa831 - git: https://git.vergara.tech/Vergara_Tech/haskell-hexstring.git - commit: fe2df6f7d63272ac147911c1573550bed1d38a37 + commit: fd1ddce73c0ad18a2a4509a299c6e93f8c6c383d - vector-0.13.0.0@sha256:fa5cac81a17a5af388716792e8b99c24b3b66770086756d0d8b23f8272a0244c,9112 - aeson-2.1.2.1@sha256:f10f3c661bd5cf57aee46b94420e47736240b8e209ac15f4bfc1a4e4d55831fa,6344 - generically-0.1.1 From 790ffec7173614b8a38f3e52c2180602f1309999 Mon Sep 17 00:00:00 2001 From: Rene Vergara Date: Fri, 9 Feb 2024 13:28:15 -0600 Subject: [PATCH 3/3] Update change log --- CHANGELOG.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 820998f..95aad13 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,6 +11,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Function to encode a human-readable transparent address - Function to generate a seed phrase +- Implementations of `Read` for types + +### Changed + + ## [0.3.0]