From 24210b1e0be8ba7319a6ec2fbbe645ae03f9143b Mon Sep 17 00:00:00 2001
From: Rene Vergara <rene@vergara.network>
Date: Tue, 29 Oct 2024 14:55:43 -0500
Subject: [PATCH] fix: optimize create transaction

---
 src/ZcashHaskell/Utils.hs | 52 ++++++++++++---------------------------
 1 file changed, 16 insertions(+), 36 deletions(-)

diff --git a/src/ZcashHaskell/Utils.hs b/src/ZcashHaskell/Utils.hs
index e060e18..bc3566b 100644
--- a/src/ZcashHaskell/Utils.hs
+++ b/src/ZcashHaskell/Utils.hs
@@ -132,40 +132,20 @@ createTransaction ::
   -> ZcashNet -- ^ the network to be used
   -> Int -- ^ target block height
   -> Bool -- ^ True to build, False to estimate fee
-  -> Either TxError HexString
+  -> HexString
 createTransaction sapAnchor orchAnchor tSpend sSpend oSpend outgoing znet bh build =
-  processResult $! txResult
-  where
-    processResult :: HexString -> Either TxError HexString
-    processResult input
-      | BS.length (hexBytes input) > 1 = Right input
-      | otherwise =
-        case head (BS.unpack $ hexBytes input) of
-          0 -> Left InsufficientFunds
-          1 -> Left ChangeRequired
-          2 -> Left Fee
-          3 -> Left Balance
-          4 -> Left TransparentBuild
-          5 -> Left SaplingBuild
-          6 -> Left OrchardBuild
-          7 -> Left OrchardSpend
-          8 -> Left OrchardRecipient
-          9 -> Left SaplingBuilderNotAvailable
-          10 -> Left OrchardBuilderNotAvailable
-          _ -> Left ZHError
-    txResult =
-      withPureBorshVarBuffer $
-      rustWrapperCreateTx
-        (case sapAnchor of
-           Nothing -> "0"
-           Just sA -> toBytes $ sapTree sA)
-        (case orchAnchor of
-           Nothing -> "0"
-           Just oA -> toBytes $ orchTree oA)
-        tSpend
-        sSpend
-        oSpend
-        outgoing
-        (znet == MainNet)
-        (fromIntegral bh)
-        build
+  withPureBorshVarBuffer $
+  rustWrapperCreateTx
+    (case sapAnchor of
+       Nothing -> "0"
+       Just sA -> toBytes $ sapTree sA)
+    (case orchAnchor of
+       Nothing -> "0"
+       Just oA -> toBytes $ orchTree oA)
+    tSpend
+    sSpend
+    oSpend
+    outgoing
+    (znet == MainNet)
+    (fromIntegral bh)
+    build