bd25f8bee3
The `newPipeline` function, used as part of `connect`, forks a listener thread. Before this commit, the thread is forked with `forkFinally`, where the thread action is run in the same mask as the parent thread. The thread is then killed by a `killThread` when closing a connection. This is typically not a problem if the mask is “masked” (or, obviously, “unmasked”), because the listener is generally blocked on a channel at some time or other, and therefore will accept the asynchronous exception thrown by `killThread`, and terminate. However, if the mask is “masked uninterruptible”, then the listener definitely doesn't receive asynchronous exceptions, and the `killThread` calls hangs, and never returns. One should probably never call `connect` in a “masked uninterruptible” action. However, it sounds better to protect the mongoDB library against the user accidentally doing so than to add a big warning saying that calling `connect` in “masked uninterruptible” will cause the program to hang down the line. Therefore, this commit uses `forkIOWithUnmask`, in order to run the thread action always in an “unmasked” state. In which case we can be sure that we can always kill the listener thread regardless of the client code. |
||
---|---|---|
.. | ||
MongoDB | ||
MongoDB.hs |